Update MaD for System.Web.HttpUtility#21299
Merged
michaelnebel merged 3 commits intogithub:mainfrom Feb 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the C# Models-as-Data (MaD) for System.Web.HttpUtility so that UrlDecode is treated as a taint-propagating method, improving dataflow tracking for SSRF and URL path traversal scenarios.
Changes:
- Add taint-propagation summaries for
System.Web.HttpUtility.UrlDecodeoverloads in the MaD YAML model. - Update library-test expected summary outputs to include the new
UrlDecodeentries. - Add a change note describing the modeling update.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| csharp/ql/lib/ext/System.Web.model.yml | Adds summary model entries marking HttpUtility.UrlDecode overloads as taint-propagating. |
| csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected | Updates expected library summary output to include UrlDecode taint flow. |
| csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected | Updates filtered expected summary output similarly. |
| csharp/ql/lib/change-notes/2026-02-09-update-system.web.httputility-model.md | Adds a change note for the modeling update (currently contains a namespace/type mistake). |
csharp/ql/lib/change-notes/2026-02-09-update-system.web.httputility-model.md
Outdated
Show resolved
Hide resolved
Contributor
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",47,12491,59,5
+ System,"``System.*``, ``System``",47,12495,59,5
- Totals,,107,14904,415,9
+ Totals,,107,14908,415,9
- System,59,47,12491,,6,5,12,,,4,1,,31,2,,6,15,17,4,3,,6378,6113
+ System,59,47,12495,,6,5,12,,,4,1,,31,2,,6,15,17,4,3,,6382,6113 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Thank you!
Lets run DCA before merging (I will start a DCA run now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update MaD for C# related to SSRF and URL path traversal scenarios.
System.Web.HttpUtility UrlDecode Method
Update model to treat
UrlDecodeas a taint method.UrlEncodeis already treated as a taint method.Example: